Messages in this thread | | | Date | Sat, 15 Apr 2006 10:29:52 -0400 | From | Prarit Bhargava <> | Subject | Re: [patch 1/3] acpi: dock driver |
| |
> +static struct dock_dependent_device * alloc_dock_dependent_device(acpi_handle handle) > +{ > + struct dock_dependent_device *dd; > + > + dd = kzalloc(sizeof(*dd), GFP_KERNEL); > + if (dd) { > + dd->handle = handle; > + INIT_LIST_HEAD(&dd->list); > + INIT_LIST_HEAD(&dd->hotplug_list); > + } > + return dd; > +} > +
Er ... what happens if dd isn't alloc'd? It looks like the rest of the code assumes that dd is a valid pointer ...
P. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |