lkml.org 
[lkml]   [2006]   [Apr]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch 1/3] acpi: dock driver

> +static struct dock_dependent_device * alloc_dock_dependent_device(acpi_handle handle)
> +{
> + struct dock_dependent_device *dd;
> +
> + dd = kzalloc(sizeof(*dd), GFP_KERNEL);
> + if (dd) {
> + dd->handle = handle;
> + INIT_LIST_HEAD(&dd->list);
> + INIT_LIST_HEAD(&dd->hotplug_list);
> + }
> + return dd;
> +}
> +

Er ... what happens if dd isn't alloc'd? It looks like the rest of the
code assumes that dd is a valid pointer ...

P.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-04-15 16:33    [W:0.947 / U:0.692 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site