Messages in this thread | | | Date | Fri, 14 Apr 2006 14:56:12 +0400 | From | Evgeniy Polyakov <> | Subject | Re: [RFC: 2.6 patch] net/netlink/: possible cleanups |
| |
On Fri, Apr 14, 2006 at 12:32:02PM +0200, Adrian Bunk (bunk@stusta.de) wrote: > On Thu, Apr 13, 2006 at 01:26:03PM -0700, David S. Miller wrote: > > From: Adrian Bunk <bunk@stusta.de> > > Date: Thu, 13 Apr 2006 18:27:10 +0200 > > > > > This patch contains the following possible cleanups plus changes related > > > to them: > > > - make the following needlessly global functions static: > > > - attr.c: __nla_reserve() > > > - attr.c: __nla_put() > > > - #if 0 the following unused global functions: > > > - attr.c: nla_validate() > > > - attr.c: nla_find() > > > - attr.c: nla_memcpy() > > > - attr.c: nla_memcmp() > > > - attr.c: nla_strcmp() > > > - attr.c: nla_reserve() > > > - genetlink.c: genl_unregister_ops() > > > - remove the following unused EXPORT_SYMBOL's: > > > - af_netlink.c: netlink_set_nonroot > > > - attr.c: nla_parse > > > - attr.c: nla_strlcpy > > > - attr.c: nla_put > > > > > > Signed-off-by: Adrian Bunk <bunk@stusta.de> ... > Anything else where a removal might be OK?
__nla_* helpers were created for small performance optimisation if reservation is heavily used. nla_* helpers were created to be used, but not to be removed or commented. Some of them are used in generic netlink family.
Others and genl_register/unregister_ops() might be used in recenly announced accounting patches. genl_unregister_ops() is supposed to be used in, for example, generic netlink exit path (which can not be called though).
Although it is always statically built systems, it is still very convenient way of netlink usage for others (future modular systems).
> cu > Adrian
-- Evgeniy Polyakov - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |