Messages in this thread | | | Date | Thu, 13 Apr 2006 16:24:32 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH 2/2] mm: fix mm_struct reference counting bugs in mm/oom_kill.c |
| |
Dave Peterson <dsp@llnl.gov> wrote: > > The patch below fixes some mm_struct reference counting bugs in > badness().
hm, OK, afaict the code _is_ racy.
But you're now calling mmput() inside read_lock(&tasklist_lock), and mmput() can sleep in exit_aio() or in exit_mmap()->unmap_vmas(). So sterner stuff will be needed.
I'll put a might_sleep() into mmput - it's a bit unexpected. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |