Messages in this thread | | | From | Roland McGrath <> | Subject | Re: [PATCH rc1-mm 1/3] coredump: some code relocations | Date | Sun, 9 Apr 2006 23:56:38 -0700 (PDT) |
| |
> This is a preparation for the next patch. No functional changes. > Basically, this patch moves '->flags & SIGNAL_GROUP_EXIT' check > into zap_threads(), and 'complete(vfork_done)' into coredump_wait > outside of ->mmap_sem protected area. > > Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
I don't see anything especially wrong with these reorganizations. I'd prefer if the commentary for the change indicated what about them was required for the following patches. Making zap_threads have a return value does seem sort of random and obfuscatory, but that is a minor nit.
Thanks, Roland - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |