Messages in this thread Patch in this message | | | From | Denis Vlasenko <> | Subject | Re: [PATCH] deinline some functions in aic7xxx drivers, save 80k of text | Date | Mon, 10 Apr 2006 08:46:17 +0300 |
| |
On Monday 10 April 2006 08:44, Denis Vlasenko wrote: > I also spotted two bugs in the process, patches > for those will follow.
Fix ahc_pci_write_config's (wrong order of arguments).
Signed-off-by: Denis Vlasenko <vda@ilport.com.ua> -- vda Fix a bug uncovered by previous change
diff -urpN linux-2.6.16.aic7/drivers/scsi/aic7xxx/aic7xxx_pci.c linux-2.6.16.aic7_2/drivers/scsi/aic7xxx/aic7xxx_pci.c --- linux-2.6.16.aic7/drivers/scsi/aic7xxx/aic7xxx_pci.c Sun Apr 9 22:11:13 2006 +++ linux-2.6.16.aic7_2/drivers/scsi/aic7xxx/aic7xxx_pci.c Sun Apr 9 22:09:45 2006 @@ -2036,12 +2036,12 @@ ahc_pci_resume(struct ahc_softc *ahc) * that the OS doesn't know about and rely on our chip * reset handler to handle the rest. */ - ahc_pci_write_config(ahc->dev_softc, DEVCONFIG, /*bytes*/4, - ahc->bus_softc.pci_softc.devconfig); - ahc_pci_write_config(ahc->dev_softc, PCIR_COMMAND, /*bytes*/1, - ahc->bus_softc.pci_softc.command); - ahc_pci_write_config(ahc->dev_softc, CSIZE_LATTIME, /*bytes*/1, - ahc->bus_softc.pci_softc.csize_lattime); + ahc_pci_write_config(ahc->dev_softc, DEVCONFIG, + ahc->bus_softc.pci_softc.devconfig, /*bytes*/4); + ahc_pci_write_config(ahc->dev_softc, PCIR_COMMAND, + ahc->bus_softc.pci_softc.command, /*bytes*/1); + ahc_pci_write_config(ahc->dev_softc, CSIZE_LATTIME, + ahc->bus_softc.pci_softc.csize_lattime, /*bytes*/1); if ((ahc->flags & AHC_HAS_TERM_LOGIC) != 0) { struct seeprom_descriptor sd; u_int sxfrctl1; | |