Messages in this thread | | | Date | Thu, 9 Mar 2006 10:35:51 +0100 | From | Pavel Machek <> | Subject | Re: [PATCH] fix kexec asm |
| |
On Út 07-03-06 21:16:34, Eric W. Biederman wrote: > Chris Mason <mason@suse.com> writes: > > > From: Michael Matz <matz@suse.de> > > > > While testing kexec and kdump we hit problems where the new kernel would > > freeze or instantly reboot. The easiest way to trigger it was to kexec a > > kernel compiled for CONFIG_M586 on an athlon cpu. Compiling > > for CONFIG_MK7 instead would work fine. > > > > The patch below fixes a few problems with the kexec inline asm. > > Thanks. Specifying the stomp of %eax in load_segments is definitely > good. The memory stomp looks excessive and if this was a fast path > I would worry about it. As it is better safe than sorry.
Why excessive? It reloads %ss, AFAICS; at that point, all the stack potentially changes from gcc's POV. Pavel -- Web maintainer for suspend.sf.net (www.sf.net/projects/suspend) wanted... - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |