Messages in this thread | | | Date | Thu, 9 Mar 2006 17:02:22 -0800 | From | Greg KH <> | Subject | Re: [PATCH 8 of 20] ipath - sysfs support for core driver |
| |
On Thu, Mar 09, 2006 at 03:59:37PM -0800, Bryan O'Sullivan wrote: > On Thu, 2006-03-09 at 15:46 -0800, Greg KH wrote: > > On Thu, Mar 09, 2006 at 03:18:49PM -0800, Roland Dreier wrote: > > > > Thanks for CC:ing me, but where were the originals of these posted? > > My patch posting script screwed up. Only Roland got them, even though > the envelopes were all correct. > > > > > +static ssize_t show_atomic_stats(struct device_driver *dev, char *buf) > > > > +{ > > > > + memcpy(buf, &ipath_stats, sizeof(ipath_stats)); > > > > + > > > > + return sizeof(ipath_stats); > > > > +} > > > > > > I think putting a whole binary struct in a sysfs attribute is > > > considered a no-no. > > > > That's an understatement, where is the large stick to thwap the author > > of this code... > > I'd like to understand why, though. As I already explained, it's a > smallish structure (< 1KB), and I can use the special binary sysfs > attribute goo for it if you insist, but ... why?
I think I explained this in my prior post enough, right? If not, please let me know.
thanks,
greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |