Messages in this thread | | | Subject | Re: [PATCH 4 of 20] ipath - support for HyperTransport devices | From | Bryan O'Sullivan <> | Date | Thu, 09 Mar 2006 15:21:41 -0800 |
| |
On Thu, 2006-03-09 at 15:01 -0800, Roland Dreier wrote:
> It seems like all these hypertransport magic constants should be in a > general .h somewhere. I'm not sure if it makes sense to put them in > <linux/pci.h>, or start a <linux/hypertransport.h>.
Either way is fine by me.
> The logic here is pretty hard to follow, and you're getting squeezed > pretty hard by indenting 5 tabs stops. Can ipath_setup_ht_config() be > split up into subfunctions?
Definitely. I mentioned this in the introductory message for the series as something I'm working on.
<b
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |