Messages in this thread | | | Date | Thu, 9 Mar 2006 13:39:29 -0500 | From | Benjamin LaHaise <> | Subject | Re: [patch 1/4] net: percpufy frequently used vars -- add percpu_counter_mod_bh |
| |
On Thu, Mar 09, 2006 at 07:41:08PM +1100, Nick Piggin wrote: > Considering that local_t has been broken so that basically nobody > is using it, now is a great time to rethink the types before it > gets fixed and people start using it.
I'm starting to get more concerned as the per-cpu changes that keep adding more overhead is getting out of hand.
> And modelling the type on the atomic types would make the most > sense because everyone already knows them.
Except that the usage models are different; local_t is most likely to be used for cpu local statistics or for sequences, where making them signed is a bit backwards.
-ben -- "Time is of no importance, Mr. President, only life is important." Don't Email: <dont@kvack.org>. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |