Messages in this thread | | | Date | Thu, 9 Mar 2006 08:34:12 -0800 | From | "Randy.Dunlap" <> | Subject | Re: [PATCH] reduce syslog clutter (take 2) |
| |
On Thu, 9 Mar 2006 03:02:57 -0800 Andrew Morton wrote:
> Tilman Schmidt <tilman@imap.cc> wrote: > > > > The current versions of the err() / info() / warn() syslog macros > > insert __FILE__ at the beginning of the message, which expands to > > the complete path name of the source file within the kernel tree. > > > > With the following patch, when used in a module, they'll insert the > > module name instead, which is significantly shorter and also tends to > > be more useful to users trying to make sense of a particular message. > > Personally, I prefer to see filenames. Or function names. Sometimes it's > rather unobvious how to go from module name to filename, due to a) multiple > .o files being linked together, b) subsystems which insist on #including .c > files in .c files (usb...) and c) the module system's cute habit of > replacing underscores with dashes in module names.
True, just using module->name or whatever means that we would (often?) have to do a lookup to see what source file it was in.
--- ~Randy - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |