Messages in this thread | | | Date | Wed, 8 Mar 2006 13:07:26 -0800 | From | Ravikiran G Thirumalai <> | Subject | Re: [patch 1/4] net: percpufy frequently used vars -- add percpu_counter_mod_bh |
| |
On Wed, Mar 08, 2006 at 03:36:42PM -0500, Benjamin LaHaise wrote: > On Wed, Mar 08, 2006 at 12:26:56PM -0800, Ravikiran G Thirumalai wrote: > > +static inline void percpu_counter_mod_bh(struct percpu_counter *fbc, long amount) > > +{ > > + local_bh_disable(); > > + fbc->count += amount; > > + local_bh_enable(); > > +} > > Please use local_t instead, then you don't have to do the local_bh_disable() > and enable() and the whole thing collapses down into 1 instruction on x86.
But on non x86, local_bh_disable() is gonna be cheaper than a cli/atomic op no? (Even if they were switched over to do local_irq_save() and local_irq_restore() from atomic_t's that is).
And if we use local_t, we will add the overhead for the non bh percpu_counter_mod for non x86 arches.
Thanks, Kiran - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |