lkml.org 
[lkml]   [2006]   [Mar]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH 0/8] Intel I/O Acceleration Technology (I/OAT)
    Date
    Evgeniy Polyakov wrote:
    > On Mon, Mar 06, 2006 at 06:44:07PM +0100, Ingo Oeser (netdev@axxeo.de) wrote:
    > > Hmm, so I should resurrect my user page table walker abstraction?
    > >
    > > There I would hand each page to a "recording" function, which
    > > can drop the page from the collection or coalesce it in the collector
    > > if your scatter gather implementation allows it.
    >
    > It depends on where performance growth is stopped.
    > From the first glance it does not look like find_extend_vma(),
    > probably follow_page() fault and thus __handle_mm_fault().
    > I can not say actually, but if it is true and performance growth is
    > stopped due to increased number of faults and it's processing,
    > your approach will hit this problem too, doesn't it?

    My approach reduced the number of loops performed and number
    of memory needed at the expense of doing more work in the main
    loop of get_user_pages.

    This was mitigated for the common case of getting just one page by
    providing a get_one_user_page() function.

    The whole problem, why we need such multiple loops is that we have
    no common container object for "IO vector + additional data".

    So we always do a loop working over the vector returned by
    get_user_pages() all the time. The bigger that vector,
    the bigger the impact.

    Maybe sth. as simple as providing get_user_pages() with some offset_of
    and container_of hackery will work these days without the disadvantages
    my old get_user_pages() work had.

    The idea is, that you'll provide a vector (like arguments to calloc) and two
    offsets: One for the page to store within the offset and one for the vma
    to store.

    If the offset has a special value (e.g MAX_LONG) you don't store there at all.

    But if the performance problem really is get_user_pages() itself
    (and not its callers), then my approach won't help at all.


    Regards

    Ingo Oeser
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-03-07 10:46    [W:0.023 / U:33.856 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site