lkml.org 
[lkml]   [2006]   [Mar]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] EDAC: core EDAC support code
    On Mon, Mar 06, 2006 at 10:52:57AM -0800, Dave Peterson wrote:
    > On Sunday 05 March 2006 07:55, Greg KH wrote:
    > > On Sun, Mar 05, 2006 at 11:18:04AM +0100, Arjan van de Ven wrote:
    > > > > +/* Main MC kobject release() function */
    > > > > +static void edac_memctrl_master_release(struct kobject *kobj)
    > > > > +{
    > > > > + debugf1("EDAC MC: " __FILE__ ": %s()\n", __func__);
    > > > > +}
    > > > > +
    > > >
    > > > ehhh how on earth can this be right?
    > >
    > > Ugh. Good catch, it isn't right. Gotta love it when people try to
    > > ignore the helpful messages the kernel gives you when you use an API
    > > wrong :(
    >
    > Is the concern here that EDAC is not waiting for the reference count
    > on the kobject to reach 0, therefore creating the possibility of the
    > module unloading while the kobject (declared statically within the
    > module) is still in use?

    Eeek, don't statically create a kobject :(

    Anyway, yes, that is a problem, if it is static, then you need to know
    it is safe to unload. Even if it is dynamic that is also true...

    thanks,

    greg k-h
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-03-06 20:56    [W:0.020 / U:0.912 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site