Messages in this thread | | | Date | Tue, 7 Mar 2006 01:57:41 +0000 | From | Al Viro <> | Subject | Re: [RFC][PATCH 1/6] prepare sysctls for containers |
| |
On Mon, Mar 06, 2006 at 05:55:48PM -0800, Dave Hansen wrote: > On Tue, 2006-03-07 at 01:24 +0000, Al Viro wrote: > > This is disgusting. Please, don't pile more and more complexity into > > sysctl_table - it's already choke-full of it and needs to be simplified, > > not to grow more crap. > > I don't completely disagree. It certainly isn't the most elegant > approach I've ever seen. > > Any ideas on ways we could simplify it? I was thinking that we could > get rid of the .data member and allow access only via the mechanism I > just introduced. It would be pretty easy to make some macros to > generate "simple" access functions for the existing global variables.
I'll resurrect the sysctl-cleanups tree and drop it on kernel.org tonight. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |