lkml.org 
[lkml]   [2006]   [Mar]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] EDAC: core EDAC support code
    On Mon, Mar 06, 2006 at 10:24:00PM +0000, Al Viro wrote:
    > On Mon, Mar 06, 2006 at 01:53:44PM -0800, Greg KH wrote:
    > > > rmmod your_turd </sys/spew/from/your_turd
    > > > and there you go. rmmod can _NOT_ wait for sysfs references to go away.
    > >
    > > To be fair, the only part of the kernel that supports the above process,
    > > is the network stack. And they implemented a special kind of lock to
    > > handle just this kind of thing.
    > >
    > > That is not something that I want the rest of the kernel to have to use.
    > > If your code blocks when doing the above thing, that's fine with me.
    >
    > One word: fail. With -EBUSY.
    >
    > > Note, you better have the module owner reference right for the above to
    > > not oops the kernel, deadlock is fine.
    >
    > Never is.

    My apologies, you are right, for some reason I thought rmmod would just
    wait for the reference count to go away. I just tested this on a lot of
    different things in sysfs and it works properly and rmmod will return an
    error saying the module is in use at this time.

    > > There is no rule that we _have_
    > > to allow rmmod to always succeed.
    >
    > Quite so, which means we can have it fail saying that module removal has
    > failed. Deadlock is not the same thing.

    Agreed.

    thanks,

    greg k-h
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-03-06 23:58    [W:0.043 / U:152.672 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site