Messages in this thread | | | Date | Sat, 4 Mar 2006 02:34:36 +0000 | From | Ralf Baechle <> | Subject | Re: [PATCH] simplify update_times (avoid jiffies/jiffies_64 aliasing problem) |
| |
On Fri, Mar 03, 2006 at 10:13:58AM -0800, john stultz wrote:
> > In kernel 2.6, update_times() is called directly in timer interrupt, > > so there is no point calculating ticks here. Then update_wall_time() > > and calc_load() can also be optimized. This also get rid of > > difference of jiffies and jiffies_64 due to compiler's optimization > > (which was reported previously with subject "jiffies_64 vs. jiffies"). > > > I'm not opposed to this change, but I'm not sure if the barrier with a > clear comment as to why its needed might be better in the short term.
A good fix is harder than it looks and with your patches on the horizon it seems the safest to get a stable 2.6.16 out of the door is the barrier.
Ralf - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |