Messages in this thread | | | Subject | Re: [patch] avoid unaligned access when accessing poll stack | From | OGAWA Hirofumi <> | Date | Sat, 01 Apr 2006 01:37:05 +0900 |
| |
Jes Sorensen <jes@sgi.com> writes:
> struct poll_list *walk; > struct fdtable *fdt; > int max_fdset; > - /* Allocate small arguments on the stack to save memory and be faster */ > - char stack_pps[POLL_STACK_ALLOC]; > + /* Allocate small arguments on the stack to save memory and be > + faster - use long to make sure the buffer is aligned properly > + on 64 bit archs to avoid unaligned access */ > + long stack_pps[POLL_STACK_ALLOC/sizeof(long)]; > struct poll_list *stack_pp = NULL;
struct poll_list stack_pps[POLL_STACK_ALLOC / sizeof(struct poll_list)];
is more readable, and probably gcc align it rightly? -- OGAWA Hirofumi <hirofumi@mail.parknet.co.jp> - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |