lkml.org 
[lkml]   [2006]   [Mar]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [patch 1/1] sys_sync_file_range()
On Wednesday March 29, akpm@osdl.org wrote:
>
> From: Andrew Morton <akpm@osdl.org>
>
> Remove the recently-added LINUX_FADV_ASYNC_WRITE and LINUX_FADV_WRITE_WAIT
> fadvise() additions, do it in a new sys_sync_file_range() syscall
> instead.

Hmmm... any chance this could be split into a sys_sync_file_range and
a vfs_sync_file_range which takes a 'struct file*' and does less (or
no) sanity checking, so I can call it from nfsd?

Currently I implement COMMIT (which has a range) with a by messing
around with filemap_fdatawrite and filemap_fdatawait (ignoring the
range) and I'd rather than a vfs helper.

And in nfsd I call filp->f_op->fsync between the two. Doesn't
sys_sync_file_range need to call into the filesystem at all?

NeilBrown
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-03-30 10:04    [W:2.263 / U:0.116 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site