Messages in this thread | | | Date | Thu, 30 Mar 2006 15:41:15 -0800 (PST) | From | Linus Torvalds <> | Subject | Re: [PATCH] isd200: limit to BLK_DEV_IDE |
| |
On Thu, 30 Mar 2006, Randy.Dunlap wrote: > > In some way, the original line made sense to me: > depends on USB_STORAGE && BLK_DEV_IDE > where we have: =y && =m > > so if USB_STORAGE_ISD200 were a tristate, it would have been limited > to 'm', but since it's a bool, it's not limited.
Oh, the original makes _tons_ of sense. It's just that it doesn't show the real dependency.
It's perfectly fine to say
bool depends on USB_STORAGE && BLK_DEV_IDE
and the bool will be true whenever usb storage and blk-dev-ide both are enabled somehow. So far so fine.
It's just that in this case, it simply wasn't enough. It didn't _just_ depend on BLK_DEV_IDE, it depended on it being available at link-time. So the original Kconfig rule made perfect sense, it just didn't match the real dependency.
Linus - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |