Messages in this thread | | | Date | Thu, 30 Mar 2006 18:50:29 +1000 | From | Nick Piggin <> | Subject | Re: [PATCH][RFC] splice support |
| |
Andrew Morton wrote: > Jens Axboe <axboe@suse.de> wrote:
>> It doesn't, I'm assuming that find_get_pages() returns consequtive pages >> atm. Would seem like the sane interface :-) > > > Yeah, sorry. It's a "gather what's presently there" thing. For writeback. > > Nick has some gang-lookup-slots code. So instead of populating an array of > page*'s you can populate an array of (effectively) page**'s. Then one > could walk that. All while holding ->tree_lock. This doesn't help ;) >
Actually while we're on the subject, my gang_lookup_slot code is just named to match lookup_slot and gang_lookup... it still only returns slots that are presently populated. Suggestions for a better name welcome?
> Probably the simplest for now is an open-coded find_get_page() loop. Later
Agreed. I think that's the best idea for now.
-- SUSE Labs, Novell Inc. Send instant messages to your online friends http://au.messenger.yahoo.com
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |