Messages in this thread | | | Date | Fri, 03 Mar 2006 17:40:48 -0800 (PST) | Subject | Re: [PATCH 1/8] [I/OAT] DMA memcpy subsystem | From | "David S. Miller" <> |
| |
From: Chris Leech <christopher.leech@intel.com> Date: Fri, 03 Mar 2006 13:42:20 -0800
> +static spinlock_t dma_list_lock;
Please use DEFINE_SPINLOCK().
> +static void dma_chan_free_rcu(struct rcu_head *rcu) {
Newline before the brace please.
> +static void dma_async_device_cleanup(struct kref *kref) {
Newline before the brace please.
> +struct dma_chan_percpu > +{
Left brace on the same line as "struct dma_chan_percpu" please.
> +struct dma_chan > +{
Similarly.
Otherwise this patch looks mostly ok. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |