lkml.org 
[lkml]   [2006]   [Mar]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 1/8] [I/OAT] DMA memcpy subsystem
    From
    From: Chris Leech <christopher.leech@intel.com>
    Date: Fri, 03 Mar 2006 13:42:20 -0800

    > +static spinlock_t dma_list_lock;

    Please use DEFINE_SPINLOCK().

    > +static void dma_chan_free_rcu(struct rcu_head *rcu) {

    Newline before the brace please.

    > +static void dma_async_device_cleanup(struct kref *kref) {

    Newline before the brace please.

    > +struct dma_chan_percpu
    > +{

    Left brace on the same line as "struct dma_chan_percpu" please.

    > +struct dma_chan
    > +{

    Similarly.

    Otherwise this patch looks mostly ok.
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-03-04 02:43    [W:3.728 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site