lkml.org 
[lkml]   [2006]   [Mar]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH][UPDATE] rtc: Added support for ds1672 control
On Tue, 28 Mar 2006 17:52:00 -0600
Kumar Gala <galak@kernel.crashing.org> wrote:

> >
> > shouldn't this be
> > if (err < 0)
> > return err;
>
> It could be, but doesn't need to. ds1672_get_control either returns
> 0 (success) or non-zero (-EIO) for failure.
>
> >> + /* read control register */
> >> + err = ds1672_get_control(client, &control);
> >> + if (err) {
> >> + dev_err(&client->dev, "%s: read error\n", __FUNCTION__);
> >> + goto exit_detach;
> >> + }
> >
> > ditto.
>
> ditto.

ok. will apply, thanks.


--

Best regards,

Alessandro Zummo,
Tower Technologies - Turin, Italy

http://www.towertech.it

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-03-29 02:00    [W:2.108 / U:0.004 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site