lkml.org 
[lkml]   [2006]   [Mar]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] Move SG_GET_SCSI_ID from sg to scsi
    On Mon, Mar 27, 2006 at 12:11:14PM +0200, Bodo Eggert wrote:
    > > > + __put_user(0, &idp->unused[0]);
    > > > + __put_user(0, &idp->unused[1]);
    > >
    > > Is it time to repurpose the unused bytes for the 64-bit LUN?
    >
    > ACK, but I didn't find out how to fill it, and having ints instead of
    > __uXX made the struct look ugly. Therefore I postponed it to a later patch.

    So we don't currently save the scsi_lun anywhere. We, er, translate it
    into a 32-bit int, and carry that around. Obviously this is going to
    have to change for things like iSCSI, but this is totally offtopic for
    your patch. So I agree with you, whoever adds the 64-bit LUN support
    gets to patch the ioctl struct too.
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-03-27 17:23    [W:0.018 / U:0.636 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site