Messages in this thread | | | Date | Mon, 27 Mar 2006 15:34:38 -0700 | From | "Mark A. Greer" <> | Subject | Re: [PATCH 2.6.16-mm1 3/3] rtc: add support for m41t81 & m41t85 chips to m41t00 driver |
| |
Hi Andrew,
On Sun, Mar 26, 2006 at 02:58:40PM -0800, Andrew Morton wrote: > "Mark A. Greer" <mgreer@mvista.com> wrote: > > > > + struct i2c_msg msgs[] = { > > + { save_client->addr, 0, 1, msgbuf }, > > + { save_client->addr, I2C_M_RD, 8, buf } > > The > > .name = value, > > form would be preferred. It reduces the possibility of silent breakage if > someone changes struct i2c_msg.
Noted. Will fix in upcoming set of new patches.
Mark - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |