lkml.org 
[lkml]   [2006]   [Mar]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2.6.16-mm1 3/3] rtc: add support for m41t81 & m41t85 chips to m41t00 driver
    "Mark A. Greer" <mgreer@mvista.com> wrote:
    >
    > + struct i2c_msg msgs[] = {
    > + { save_client->addr, 0, 1, msgbuf },
    > + { save_client->addr, I2C_M_RD, 8, buf }

    The

    .name = value,

    form would be preferred. It reduces the possibility of silent breakage if
    someone changes struct i2c_msg.
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-03-27 01:06    [W:0.021 / U:60.512 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site