lkml.org 
[lkml]   [2006]   [Mar]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH] Move SG_GET_SCSI_ID from sg to scsi
    From
    Date
    On Sun, 2006-03-26 at 21:28 +0200, Bodo Eggert wrote:
    > Having a SCSI ID is a generic SCSI property, therefore reading it should
    > not be restricted to sg. The SCSI_IOCTL_GET_IDLUN from scsi is limited
    > below the kernel data types, so it isn't an adequate replacement.
    >
    > This patch moves SG_GET_SCSI_ID from sg to scsi while renaming it to
    > SCSI_IOCTL_GET_PCI. Additionally, I renamed struct sg_scsi_id to struct
    > scsi_ioctl_id, since it is no longer restricted to sg. The corresponding
    > typedef will be gone.


    To be honest, I think this is the wrong direction; this ioctl seems to
    be a bad idea (it exposes the SPI parameters... while SPI is only one of
    many nowadays). Expanding the use of such a thing... please no.

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-03-26 21:54    [W:0.021 / U:1.732 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site