Messages in this thread | | | Date | Sun, 26 Mar 2006 13:03:03 +1000 | From | Nick Piggin <> | Subject | Re: [PATCH 2.6.16-mm1 1/2] sched_domain: handle kmalloc failure |
| |
Andrew Morton wrote: > Srivatsa Vaddagiri <vatsa@in.ibm.com> wrote: >
>>If we decide to return an error, then it has to be percolated all the >>way down (for ex: update_cpu_domains should now have to return an error >>too if partition_sched_domains returns an error)? > > > Well, when is this code called? It would be at boot time, in which case > the allocations will succeed (if not, the boot fails) or at cpu/node > hot-add, in which case the appropriate response is to fail to bring up the > new cpu/node. > > It's better to send the administrator back to work out why we ran out of > memory than to appear to have brought the new cpu/node online, only to have > it run funny. > > I think? >
I agree, for bootup/hot-add.
Not so sure about exclusive cpusets.
-- SUSE Labs, Novell Inc. Send instant messages to your online friends http://au.messenger.yahoo.com
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |