lkml.org 
[lkml]   [2006]   [Mar]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: Parenthesize macros in xfs
Date
Jan Engelhardt <jengelh@linux01.gwdg.de> writes:

> diff -dpru xfs-mod-01/support/qsort.c xfs-mod-02/support/qsort.c
> --- xfs-mod-01/support/qsort.c 2005-09-23 05:51:28.000000000 +0200
> +++ xfs-mod-02/support/qsort.c 2006-03-25 22:20:37.055287000 +0100
> @@ -55,13 +55,14 @@ swapfunc(char *a, char *b, int n, int sw
> swapcode(char, a, b, n)
> }
>
> -#define swap(a, b) \
> +#define swap(a, b) do { \
> if (swaptype == 0) { \
> long t = *(long *)(a); \
> *(long *)(a) = *(long *)(b); \
> *(long *)(b) = t; \
> } else \
> - swapfunc(a, b, es, swaptype)
> + swapfunc(a, b, es, swaptype) \
> +} while(0)
^^

Missing semicolon.

Andreas.

--
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-03-25 23:42    [W:0.054 / U:0.136 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site