[lkml]   [2006]   [Mar]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: Two comments on the H.323 conntrack/NAT helper
    [The hotmail address of the author doesn't work, CCed sourceforge-address]

    Adrian Bunk wrote:
    > Two comments on the H.323 conntrack/NAT helper:
    > - the function prototypes in ip_nat_helper_h323.c are _ugly_,
    > please move them to a header file

    Their ugliness is because of the current API, which cleaned up
    quite a lot of the surrounding code, but requires this ugliness
    from each helper. I would like to keep them visible as a reminder
    that a cleaner solution is wanted, but moving them to header
    files certainly sound like a good idea to eliminate the risk
    of prototype conflicts. But please do this for all helpers
    at once.

    > - is there a reason for not using EXPORT_SYMBOL_GPL?

    I would prefer that too.
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2006-03-24 03:05    [W:0.025 / U:88.388 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site