Messages in this thread | | | Date | Thu, 23 Mar 2006 14:40:28 -0700 | From | "Mark A. Greer" <> | Subject | Re: [PATCH, RFC] Stop using tasklet in ds1374 RTC driver |
| |
On Thu, Mar 23, 2006 at 01:42:51PM -0700, Randy Vinson wrote: > Jean Delvare wrote: > >Hi all, > > > >I have the following patch, which addresses a might-sleep-in-tasklet > >issue in the ds1374 driver. I'm not too sure if the new code is right > >or not, as I have never been using workqueues before, and I also don't > >have a DS1374 chip to test my changes on. > > > >Can anyone comment on the patch and tell me if anything is wrong? > > > >Can anyone with a DS1374 chip please test it? > > I've attached a similar patch that has been tested using the DS1374 on the > Freescale MPC8349MDS reference system. It is patterned after a similar > change made to the m41t00 driver. The changes work, but I am also > unfamiliar with workqueues, so my patch may not be any better.
I'm no expert in workqueues either; however, after reading http://lwn.net/Articles/23634/, I believe that its unnecessary for an rtc driver to have its own workqueue since rtc writes aren't particularly time-critical. If I am correct, then Randy's patch uses the proper wq calls.
Agree?
Mark - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |