[lkml]   [2006]   [Mar]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Subjecteither bug or unnecessary code in exit_mm()

In the last few kernels (at least as far back as 2.6.10), exit_mm()
looks like this:

static void exit_mm(struct task_struct * tsk)
struct mm_struct *mm = tsk->mm;
mm_release(tsk, mm);
if (!mm)

while mm_release() looks like this:

void mm_release(struct task_struct *tsk, struct mm_struct *mm)
if (tsk->clear_child_tid && atomic_read(&mm->mm_users) > 1) {

If it's valid to call exit_mm() with tsk->mm being NULL, then it seems
like we'll get problems when we dereference it unconditionally in

If mm_release() is valid, then the check for !mm in exit_mm() is
unnecessary but there should probably be a comment.

Can someone tell me which one it is?


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

 \ /
  Last update: 2006-03-23 22:37    [from the cache]
©2003-2014 Jasper Spaans. hosted at Digital Ocean