Messages in this thread | | | Date | Mon, 20 Mar 2006 22:39:45 +0100 (MET) | From | Jan Engelhardt <> | Subject | Re: Parenthesize macros in xfs |
| |
>> Hello xfs list, > >Hi Jan, > >> while browsing through the xfs/linux source, I noticed that many macros do >> not do proper bracing. I have started to cook up a patch, but would like >> feedback first before I continue for nothing. >> It goes like this: >> ... > >That looks fine. Please be sure to work on the -mm tree or on >CVS on oss.sgi.com, so as to reduce your level of patch conflict. >
Hm, would not it even be better to make them 'static inline' functions?
Jan Engelhardt -- | Software Engineer and Linux/Unix Network Administrator - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |