lkml.org 
[lkml]   [2006]   [Mar]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH]use kzalloc in vfs where appropriate
    On Monday 20 March 2006 09:25, Pekka Enberg wrote:
    > > > Rewriting the test as:
    > > > n!=0 && n > INT_MAX / size
    > > > saves the division because size is much likelier to be a constant, and indeed
    > > > the code is better:
    > > >
    > > > cmpq $268435455, %rax
    > > > movq $0, 40(%rsp)
    > > > ja .L313
    > > >
    > > > Is there anything I am missing?

    On Mon, 20 Mar 2006, Denis Vlasenko wrote:
    > You may drop "n!=0" part, but you must check size!=0.
    > Since if size is 0, kcalloc returns NULL, then
    >
    > if (!size || n > INT_MAX / size)
    > return NULL;

    Uh, oh, I must be getting blind to have missed that...

    Pekka
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-03-20 14:19    [W:0.020 / U:30.912 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site