Messages in this thread | | | From | Oliver Neukum <> | Subject | Re: [PATCH]use kzalloc in vfs where appropriate | Date | Mon, 20 Mar 2006 14:14:19 +0100 |
| |
Am Montag, 20. März 2006 14:08 schrieb Denis Vlasenko: > On Monday 20 March 2006 09:25, Pekka Enberg wrote: > > > Rewriting the test as: > > > n!=0 && n > INT_MAX / size > > > saves the division because size is much likelier to be a constant, and indeed > > > the code is better: > > > > > > cmpq $268435455, %rax > > > movq $0, 40(%rsp) > > > ja .L313 > > > > > > Is there anything I am missing? > > You may drop "n!=0" part, but you must check size!=0. > Since if size is 0, kcalloc returns NULL, then
Why? size == 0 is a bug. We want to oops here.
Regards Oliver - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |