lkml.org 
[lkml]   [2006]   [Mar]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: OOPS: 2.6.16-rc6 cpufreq_conservative


On Sun, 19 Mar 2006, Andrew Morton wrote:
>
> Also, optimise any_online_cpu() out of existence on CONFIG_SMP=n.
>
> This function seems inefficient. Can't we simply AND the two masks, then use
> find_first_bit()?

Then you'd need to generate a temporary cpumask thing. Not a big deal as
long as it fits in an "unsigned long", but since the online-cpu thing is
likely dense in any relevant cpu-mask, I actually think "any_online_cpu()"
as it stands now is likely to be simpler/more efficient than generating a
temporary mask.

Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2009-11-18 23:46    [W:0.045 / U:2.856 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site