lkml.org 
[lkml]   [2006]   [Mar]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] - make sure that EFI variable data size is always 64 bit
On Sun, Mar 19, 2006 at 03:29:01PM -0600, Matt Domsch wrote:

> NAK. efibootmgr, the main userspace consumer of this struct, also
> thinks this is an "unsigned long".

Hm. My copy of efibootmgr has:

typedef struct _efi_variable_t {
efi_char16_t VariableName[1024/sizeof(efi_char16_t)];
efi_guid_t VendorGuid;
uint64_t DataSize;
uint8_t Data[1024];
efi_status_t Status;
uint32_t Attributes;
} __attribute__((packed)) efi_variable_t;

which certainly makes it look like it's expecting a 64-bit value. But
checking the spec does seem to suggest that datasize is a native value,
so presumably it's an efibootmgr bug rather than a kernel one? In that
case, this ought to be dropped.

--
Matthew Garrett | mjg59@srcf.ucam.org
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-03-19 22:38    [W:0.063 / U:0.216 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site