Messages in this thread Patch in this message | | | From | Jesper Juhl <> | Subject | [PATCH] fix potential null pointer deref in quota | Date | Sat, 18 Mar 2006 23:08:04 +0100 |
| |
The coverity checker noticed that we may pass a NULL super_block to do_quotactl() that dereferences it. Dereferencing NULL pointers is bad medicine, better check and fail gracefully.
Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com> ---
fs/quota.c | 3 +++ 1 files changed, 3 insertions(+)
--- linux-2.6.16-rc6-orig/fs/quota.c 2006-03-12 14:19:02.000000000 +0100 +++ linux-2.6.16-rc6/fs/quota.c 2006-03-18 23:03:32.000000000 +0100 @@ -231,6 +231,9 @@ static int do_quotactl(struct super_bloc { int ret; + if (!sb) + return -ENODEV; + switch (cmd) { case Q_QUOTAON: { char *pathname;
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |