lkml.org 
[lkml]   [2006]   [Mar]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] fix free swap cache latency
Hugh Dickins <hugh@veritas.com> wrote:
>
> (*zap_work)--;
> continue;
> }
> +
> + (*zap_work) -= PAGE_SIZE;

Sometimes we subtract 1 from zap_work, sometimes PAGE_SIZE. It's in units
of bytes, so PAGE_SIZE is correct. Although it would make sense to
redefine it to be in units of PAGE_SIZE. What's up with that?

Even better, define it in units of "approximate number of touched
cachelines". After all, it is a sort-of-time-based thing.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-03-17 02:38    [W:2.821 / U:0.156 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site