[lkml]   [2006]   [Mar]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [git patches] net driver fixes

On Thu, 16 Mar 2006, Jeff Garzik wrote:
> Please pull from 'upstream-fixes' branch of

The commit comments for the Chelsio driver fix are a bit unfortunate.

The array clearly _does_ have three elements, it's just that the code used
to access the fourth (that didn't exist), and now it accesses the third.

So when the commit says "The array should contain 2 elements" it's just
being really confused.

Of course, using an array index of "cmdQ_restarted[2]" without any
explanation for why it's index 2, the bug was inevitable. Maybe a symbolic
value for the magic array indices?

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

 \ /
  Last update: 2009-11-18 23:46    [W:0.033 / U:2.000 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site