Messages in this thread Patch in this message | | | Date | Thu, 16 Mar 2006 15:10:28 +0800 | From | Eugene Teo <> | Subject | Re: [PATCH] Hamradio: Fix a NULL pointer dereference in net/hamradio/6pack.c |
| |
<quote sender="Eugene Teo"> > Pointer sp is dereferenced before NULL check. > > Coverity bug #816 > > Signed-off-by: Eugene Teo <eugene.teo@eugeneteo.net>
Ignore the previous patch please. Here's a resend.
-- Pointer sp is dereferenced before NULL check.
Coverity bug #816
Signed-off-by: Eugene Teo <eugene.teo@eugeneteo.net>
--- linux-2.6/drivers/net/hamradio/6pack.c~ 2006-03-15 10:05:35.000000000 +0800 +++ linux-2.6/drivers/net/hamradio/6pack.c 2006-03-16 15:08:43.000000000 +0800 @@ -727,12 +727,14 @@ static int sixpack_ioctl(struct tty_stru unsigned int cmd, unsigned long arg) { struct sixpack *sp = sp_get(tty); - struct net_device *dev = sp->dev; + struct net_device *dev; unsigned int tmp, err; if (!sp) return -ENXIO; + dev = sp->dev; + switch(cmd) { case SIOCGIFNAME: err = copy_to_user((void __user *) arg, dev->name, -- 1024D/A6D12F80 print D51D 2633 8DAC 04DB 7265 9BB8 5883 6DAA A6D1 2F80 main(i) { putchar(182623909 >> (i-1) * 5&31|!!(i<7)<<6) && main(++i); } - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |