Messages in this thread | | | Date | Thu, 16 Mar 2006 10:10:25 -0800 | From | Greg KH <> | Subject | Re: [Bug? Report] kref problem |
| |
On Thu, Mar 16, 2006 at 09:00:19PM +0300, Artem B. Bityutskiy wrote: > On Thu, 2006-03-16 at 09:20 -0800, Greg KH wrote: > > Again, why are you trying to call the sysfs raw functions? You are not > > registering the kobject with the kobject core, so bad things are > > happening. Why not call kobject_register() or kobject_add(), like it is > > documented to do so? > > Well, we were discussing this with you some time ago, and you pointed me > to these raw functions. My stuff just does not fit device/driver/bu > modes and you said I have to create whatever sysfs hierarchy I want with > the raw functions.
Yes, but you still need to register your kobject :)
> kobject_register()/kobject_del() instead of > sysfs_create_dir()/sysfs_remove_dir() solved my problem, thanks. Just to > refine this, I'm still going to use > sysfs_create_file()/sysfs_remove_file() to create whatever attributes I > want, is this right?
Yes, that should be fine.
> I've just noticed similarity in naming: sysfs_remove_file() creates a > file, so the symmetrical sysfs_create_dir() creates a directory. So just > started using it. From the names it was not obvious that I could > not. :-)
Hm, perhaps I'll just remove the export for that function as the only thing that should use that is the kobject core, and that can't be built as a module.
thanks,
greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |