lkml.org 
[lkml]   [2006]   [Mar]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch 1/1] consolidate TRUE and FALSE
On Thu, Mar 16, 2006 at 02:01:28AM -0800, akpm@osdl.org wrote:
>
> From: Andrew Morton <akpm@osdl.org>
>
> We have no less than 65 implementations of TRUE and FALSE in the tree, so the
> inevitable happened:
>
> In file included from drivers/pci/hotplug/ibmphp_core.c:40:
> drivers/pci/hotplug/ibmphp.h:409:1: warning: "FALSE" redefined
> In file included from include/acpi/acpi.h:55,
> from drivers/pci/hotplug/pci_hotplug.h:187,
> from drivers/pci/hotplug/ibmphp.h:33,
> from drivers/pci/hotplug/ibmphp_core.c:40:
> include/acpi/actypes.h:336:1: warning: this is the location of the previous definition
>
> The patch implements TRUE and FALSE in include/linux/kernel.h and removes all
> the private versions.

NAK. Simply remove those and be done with that. It's bad style and we
certainly don't need to propagate that lossage.

..oO[and no, #define BEGIN { is also not kernel.h fodder]
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
\
 
 \ /
  Last update: 2006-03-16 17:51    [from the cache]
©2003-2014 Jasper Spaans. hosted at Digital Ocean