Messages in this thread Patch in this message | | | Date | Thu, 16 Mar 2006 08:54:54 +0800 | From | Eugene Teo <> | Subject | Fix sb_mixer use before validation |
| |
I know that OSS is obsoleted by ALSA but here's a patch anyways.
Eugene
-- dev should be validated before it is being used as index to array.
Coverity bug #871
Signed-off-by: Eugene Teo <eugene.teo@eugeneteo.net>
--- linux-2.6/sound/oss/sb_mixer.c~ 2006-03-15 10:05:45.000000000 +0800 +++ linux-2.6/sound/oss/sb_mixer.c 2006-03-16 08:28:48.000000000 +0800 @@ -273,14 +273,14 @@ int regoffs; unsigned char val; + if ((dev < 0) || (dev >= devc->iomap_sz)) + return -EINVAL; + regoffs = (*devc->iomap)[dev][LEFT_CHN].regno; if (regoffs == 0) return -EINVAL; - if ((dev < 0) || (dev >= devc->iomap_sz)) - return -EINVAL; - val = sb_getmixer(devc, regoffs); change_bits(devc, &val, dev, LEFT_CHN, left); -- 1024D/A6D12F80 print D51D 2633 8DAC 04DB 7265 9BB8 5883 6DAA A6D1 2F80 main(i) { putchar(182623909 >> (i-1) * 5&31|!!(i<7)<<6) && main(++i); } - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |