Messages in this thread | | | Subject | Re: [PATCH 2.6.16-rc6] Promise SuperTrak driver | From | Arjan van de Ven <> | Date | Tue, 14 Mar 2006 10:40:03 +0100 |
| |
On Tue, 2006-03-14 at 04:27 -0500, Jeff Garzik wrote: > Arjan van de Ven wrote: > >>>>+struct st_sgitem { > >>>>+struct st_sgtable { > >>>>+struct handshake_frame { > >>>>+struct req_msg { > >>>>+struct status_msg { > >>> > >>>Has this all been tested on big-endian hardware? > >>> > >> > >>No. It was only tested on i386 and x86-64 machines. > > > > > > you'll want those to be __attribute__((packed)) as well btw > > I thought that was unnecessary if the struct members are ordered such > that compiler would not add padding?
the rules for when padding gets added are different for each platform though; worst case of adding it is that it serves as documentation that the layout matters :)
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |