[lkml]   [2006]   [Mar]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH][2/4] sched: add discrete weighted cpu load function
    Con Kolivas wrote:
    > Peter Williams writes:
    >> Con Kolivas wrote:
    >>> +unsigned long weighted_cpuload(const int cpu)
    >>> +{
    >>> + return (cpu_rq(cpu)->raw_weighted_load);
    >>> +}
    >>> +
    >> Wouldn't this be a candidate for inlining?
    > That would make it unsuitable for exporting via sched.h.

    If above_background_load() were implemented inside sched.c instead of in
    sched.h there would be no need to export weighted_cpuload() would there?
    This would allow weighted_cpuload() to be inline and the efficiency
    would be better as above_background_load() doesn't gain a lot by being
    inline as having weighted_cpulpad() non inline means that it's doing a
    function call several times in a loop i.e. it may save one function call
    by being inline but requires (up to) one function call for every CPU.

    The other way around the cost would be just one function call.

    Peter Williams

    "Learning, n. The kind of ignorance distinguishing the studious."
    -- Ambrose Bierce
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2006-03-14 23:12    [W:0.023 / U:0.120 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site