lkml.org 
[lkml]   [2006]   [Mar]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Fix SCO on Broadcom Bluetooth adapters
On Tue, 14 Mar 2006 12:12:48 +0100 Olivier Galibert wrote:

> Broadcom USB Bluetooth adapters report a maximum of zero SCO packets
> in-flight, killing SCO. Use a reasonable count instead in that case.
>
> Signed-off-by: Olivier Galibert <galibert@pobox.com>
>
> ---
>
> I don't think that could be reasonably done as a quirk. Simple
> examination of the .inf coming with the windows driver shows that 100+
> different models may be having this problem. Also, it can't break
> already working adapters, so why bother.
>
> net/bluetooth/hci_event.c | 7 +++++++
> 1 files changed, 7 insertions(+), 0 deletions(-)
>
> diff --git a/net/bluetooth/hci_event.c b/net/bluetooth/hci_event.c
> --- a/net/bluetooth/hci_event.c
> +++ b/net/bluetooth/hci_event.c
> @@ -324,6 +324,13 @@ static void hci_cc_info_param(struct hci
> hdev->acl_pkts = hdev->acl_cnt = __le16_to_cpu(bs->acl_max_pkt);
> hdev->sco_pkts = hdev->sco_cnt = __le16_to_cpu(bs->sco_max_pkt);
>
> + /* Some buggy USB bluetooth adapters, Broadcom in
> + particular, answer zero as the max number of sco
> + packets in flight. Use a reasonable value
> + instead */
> + if (hdev->sco_pkts == 0)
> + hdev->sco_pkts = hdev->sco_cnt = 8

missing trailing ';'

---
~Randy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-03-14 18:40    [W:0.144 / U:0.064 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site