Messages in this thread | | | Date | Tue, 14 Mar 2006 15:25:59 +0000 | From | Christoph Hellwig <> | Subject | Re: [RFC, PATCH 3/24] i386 Vmi interface definition |
| |
On Mon, Mar 13, 2006 at 10:01:14AM -0800, Zachary Amsden wrote: > Master definition of VMI interface, including calls, constants, and > interface version.
This is a totally horrible style. There's absolutely no need to find your own sized integer types, please use the standard kernel ones. Also don't use camel case and #pack but rather __attribute__. Also please avoid // comments.
Also please remove all the historical version garbage, we don't care about that. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |