lkml.org 
[lkml]   [2006]   [Mar]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] fix memory leak in mm/slab.c::alloc_kmemlist()
On 3/12/06, Andrew Morton <akpm@osdl.org> wrote:
> Jesper Juhl <jesper.juhl@gmail.com> wrote:
> >
> >
> > The Coverity checker found that we may leak memory in
> > mm/slab.c::alloc_kmemlist()
> > This should fix the leak and coverity bug #589
> >
[snip]
>
> It's more complicated than that. We can also leak new_alien. And if any
> allocation in that for_each_online_node() loop fails I guess we need to
> back out all the allocations we've done thus far, which means another loop.
> ug.
>
Ok, I'll take a second (and much more thorough) look at it tonight.
And I'll be sure to describe whatever changes I make and the reasoning
behind.


> Patches against rc6-mm1 would be preferred please, that code's changed
> quite a bit.
>
Sure thing.


--
Jesper Juhl <jesper.juhl@gmail.com>
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-03-13 08:37    [W:0.287 / U:0.192 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site