lkml.org 
[lkml]   [2006]   [Mar]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2.6.15.3 1/1] ACPI: Atlas ACPI driver
    On 3/8/06, Yu, Luming <luming.yu@intel.com> wrote:
    > I suggest LCD support in hotkey.c like:
    > http://bugzilla.kernel.org/attachment.cgi?id=6843&action=view
    >
    > Config userspace acpi daemon to respond events by evoking
    > LCD._BCM with command:
    > echo -n xx > /sys/hotkey/brightness.
    >

    A quick question here. I took a look at your patch adding hotkeylib. I
    see brightness_show/store callbacks and I think they end up calling
    write_acpi_int to do the actual method eval.

    So I assume my action_method has got to be "_BCM". I don't have a poll
    method but it looks like I'll need to put something in there since you
    check for it. Atlas has a _BCL. I guess I'll just use that.

    + if(!poll_handle || !poll_method || !action_handle || !action_method)
    + goto do_fail;

    From what I can tell, it looks like I have to use ACPILCD00 as my HID
    in this hotkey code. Right? So basically, it'd be something like:
    {
    .ids = "ACPILCD00",
    .name = "brightness",
    .poll_method = "_BCL",
    .action_method = "_BCM",
    .min = 1,
    .max = 31,
    .id = 10001,
    },

    So if I get that working, is that what you are saying is the right way
    to do brightness support for limited devices like Atlas? I guess it
    feels kind of odd to me because it's an LCD device rather than a
    hotkey device. But afaict it looks like doing that will work fine and
    have the added benefit of not creating any new /proc entries. So let
    me know if I understood you correctly.

    By the way, I just applied your sequence of patches from
    http://bugzilla.kernel.org/show_bug.cgi?id=5749 to my tree. You know,
    if it's okay with you, I'll post the full diff from below to your bug
    report so that the next person doesn't have to cherrypick.

    wget "http://bugzilla.kernel.org/attachment.cgi?id=6839&action=view"
    wget "http://bugzilla.kernel.org/attachment.cgi?id=6840&action=view"
    wget "http://bugzilla.kernel.org/attachment.cgi?id=6841&action=view"
    wget "http://bugzilla.kernel.org/attachment.cgi?id=6842&action=view"
    wget "http://bugzilla.kernel.org/attachment.cgi?id=6843&action=view"
    wget "http://bugzilla.kernel.org/attachment.cgi?id=7061&action=view"
    wget "http://bugzilla.kernel.org/attachment.cgi?id=7060&action=view"

    Thanks,
    jayakumar
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-03-13 07:40    [W:0.024 / U:118.200 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site