Messages in this thread | | | From | "Sean Hefty" <> | Subject | RE: [PATCH 5/6 v2] IB: IP address based RDMA connection manager | Date | Mon, 13 Mar 2006 09:11:34 -0800 |
| |
> > +static void cma_detach_from_dev(struct rdma_id_private *id_priv) > > +{ > > + list_del(&id_priv->list); > > + if (atomic_dec_and_test(&id_priv->cma_dev->refcount)) > > + wake_up(&id_priv->cma_dev->wait); > > + id_priv->cma_dev = NULL; > > +} > >doesn't need to do atomic_dec_and_test(), because it is never dropping >the last reference to id_priv (and in fact if it was, the last line >would be a use-after-free bug).
It's dropping the reference on cma_dev, as opposed to id_priv.
- Sean
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |